Suggestion: Allow ControlInfoPropertyNames.Footnote in UriProperty

[midora]

Because ControlInfoPropertyNames.Description is used to set the text of the UriProperty allow ControlInfoPropertyNames.Footnote (as used by BooleanProperty).

Or maybe allow Footnote for all properties (in addition to Description just o be consistent).

In general I would prefer that .ButtonText sets the text of BooleanProperty and UriProperty and Description would only be used for the description. But it's a little bit late now 😉

 

[Rick Brewster]

wait why is this in the Translation and Localization section?

[midora]

Because I did a mistake...

[Rick Brewster]

I've filed a bug for v4.4.x, I may be able to get a look at this, or maybe @toe_head2001 or @BoltBait will grab the task. I'm also willing to pull it in for 4.3.9 if it's simple enough (which it should be).

[midora]

I was surprised that switch allows to test for a class type...

 

        public void SetPropertyDescription(Property property)
        {
            ControlInfoPropertyNames cipn;
            switch (property)
            {
                case BooleanProperty:
                case UriProperty:
                    cipn = ControlInfoPropertyNames.Footnote;
                    break;
                default:
                    cipn = ControlInfoPropertyNames.Description;
                    break;
            }
            var descriptionText = Context.MapKeyToText(property.Name + ".Description", "");
            Info.SetPropertyControlValue(property.Name, cipn, descriptionText);
        }

 

[otuncelli]

@midoraThis is a feature of C# 9.0.

 

If you use variables it works in C# 7.0 as well  

            switch (property)
            {
                case BooleanProperty _:
                case UriProperty _:
                    cipn = ControlInfoPropertyNames.Footnote;
                    break;
                default:
                    cipn = ControlInfoPropertyNames.Description;
                    break;
            }

 

[midora]

VS proposes to use a switch expression

 

            var cipn = property switch
            {
                BooleanProperty or UriProperty => ControlInfoPropertyNames.Footnote,
                _ => ControlInfoPropertyNames.Description,
            };

 

I guess I should take the time to have a look to all the new c# features.

But on the other side I have to debug now Xamarin code on iOS and should not forget the old stuff 😉